◐ Shell
reader mode source ↗
Skip to content

Support CODDTest for DuckDB#1224

Open
DerZc wants to merge 9 commits into
sqlancer:mainfrom
DerZc:coddtest_duckdb
Open

Support CODDTest for DuckDB#1224
DerZc wants to merge 9 commits into
sqlancer:mainfrom
DerZc:coddtest_duckdb

Conversation

@DerZc

@DerZc DerZc commented Apr 30, 2025

Copy link
Copy Markdown
Contributor

Support CODDTest for DuckDB. This is a sub-task of the larger implementation tracked in #1054.

@mrigger mrigger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Sorry for the late review. I looked through the files and added some comments and suggestions. Let me know once you've had a look at them. In particular, the DuckdbCODDTestOracle is difficult to understand, and I think it will be tough to maintain and extend it in the future. However, I also understand that refactoring this now might be challenging. I'm fine with merging the current state, perhaps after addressing some of the easy issues, but it would also be good to think about what we could improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants