{{ message }}
Support CODDTest for DuckDB#1224
Open
DerZc wants to merge 9 commits into
Open
Conversation
mrigger
reviewed
Jun 7, 2025
mrigger
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the late review. I looked through the files and added some comments and suggestions. Let me know once you've had a look at them. In particular, the DuckdbCODDTestOracle is difficult to understand, and I think it will be tough to maintain and extend it in the future. However, I also understand that refactoring this now might be challenging. I'm fine with merging the current state, perhaps after addressing some of the easy issues, but it would also be good to think about what we could improve.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Support CODDTest for DuckDB. This is a sub-task of the larger implementation tracked in #1054.