◐ Shell
reader mode source ↗
Skip to content

Fix#95: support host and port arguments configuration for different DBMSs in SQLancer#315

Merged
mrigger merged 22 commits into
masterfrom
unknown repository
Mar 25, 2021
Merged

Fix#95: support host and port arguments configuration for different DBMSs in SQLancer#315
mrigger merged 22 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 12, 2021

Copy link
Copy Markdown

What problem does this PR solve?

Issue number: #95

Summary

Supporting host/port arguments for the follow databases:

  • PostgreSQL
  • MySQL
  • MariaDB
  • TiDB
  • Clickhouse
  • CockRoachDB
  • Citus extends PostgreSQL

Release note

No release note

@mrigger mrigger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks a lot for the PR. The changes look great overall.

I think that we need to expose the default port and host to the user in some way. See my thoughts in this respect as an in-line comment. Let me know if you have any follow-up questions or thoughts.

Thanks again for the great PR!

@ghost

ghost commented Mar 18, 2021

Copy link
Copy Markdown
Author

TBR. Please let me know if this version can be merged? Thank you @mrigger

@mrigger

mrigger commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

Sorry for the delayed response! As mentioned, it would be great to address the two concerns I mentioned: (1) we want to display the default values that each DBMS uses to the user as part of the help text and (2) not use invalid default values (i.e., either use null or implement them as DBMS-specific options). Please let me know if there are any unclarities, and I will provide more details.

@ghost

ghost commented Mar 20, 2021

Copy link
Copy Markdown
Author

TBR @mrigger
If there is anything inappropriate, please let me know!

@mrigger

mrigger commented Mar 20, 2021

Copy link
Copy Markdown
Contributor

TBR @mrigger
If there is anything inappropriate, please let me know!

Thanks a lot again for your changes and for your patience! After introducing constants and using them to replace the hard-coded values, we can likely merge the PR.

@ghost

ghost commented Mar 21, 2021

Copy link
Copy Markdown
Author

TBR @mrigger Thanks for your suggestions. Please review the latest revisions, and if necessary, please suggest revisions.

@mrigger

mrigger commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Thanks a lot for your PR and for incorporating my improvement suggestions. I highly appreciate it! Merging the PR now.

For future PRs, please pay attention to a "clean" commit history by avoid merges as well as rewriting the history for incorporating feedback (and removing accidentally committed files), see https://github.com/sqlancer/sqlancer/blob/master/CONTRIBUTING.md#commit-history.

@mrigger mrigger merged commit 695dda5 into sqlancer:master Mar 25, 2021
@ghost

ghost commented Mar 25, 2021

Copy link
Copy Markdown
Author

Thanks a lot for your PR and for incorporating my improvement suggestions. I highly appreciate it! Merging the PR now.

For future PRs, please pay attention to a "clean" commit history by avoid merges as well as rewriting the history for incorporating feedback (and removing accidentally committed files), see https://github.com/sqlancer/sqlancer/blob/master/CONTRIBUTING.md#commit-history.

Thanks for your suggestions. It’s a great honor to contribute to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants