◐ Shell
reader mode source ↗
Skip to content

Aachen Turbine Tutorial#56

Open
alecappiello wants to merge 4 commits into
su2code:developfrom
alecappiello:develop
Open

Aachen Turbine Tutorial#56
alecappiello wants to merge 4 commits into
su2code:developfrom
alecappiello:develop

Conversation

@alecappiello

@alecappiello alecappiello commented Dec 17, 2024

Copy link
Copy Markdown

config and mesh files for the Aachen Turbine tutorial

@alecappiello

alecappiello commented Dec 17, 2024

Copy link
Copy Markdown
Author

@joshkellyjak, could you review this PR?

@alecappiello

alecappiello commented Jan 15, 2025

Copy link
Copy Markdown
Author

@joshkellyjak, could you review this PR?

Hey Josh, could you have a look at this, so that we can finally close it?

pcarruscag
pcarruscag reviewed Jan 15, 2025
View reviewed changes

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Is this a copy of the test in TestCases?

@alecappiello

alecappiello commented Jan 16, 2025

Copy link
Copy Markdown
Author

Is this a copy of the test in TestCases?

Hi Pedro, the mesh is the same

@pcarruscag

pcarruscag commented Jan 16, 2025

Copy link
Copy Markdown
Member

Then can we put this case in the tutorials.py regression and remove the one from TestCases?

joshkellyjak
joshkellyjak reviewed Jan 16, 2025
View reviewed changes

@joshkellyjak joshkellyjak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Agree that this should be run as a regression test also

@alecappiello

alecappiello commented Feb 7, 2025

Copy link
Copy Markdown
Author

Then can we put this case in the tutorials.py regression and remove the one from TestCases?

Do you mean using this mesh in the tutorial files also for the regression test? If so, this change should not affect this PR. In case, could you guys give the final approve for this PR?

@pcarruscag

pcarruscag commented Feb 7, 2025

Copy link
Copy Markdown
Member

Everything we put in tutorials must have a regression test in tutorials.py, no test, no approval.

@bigfooted bigfooted mentioned this pull request Oct 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarruscag pcarruscag pcarruscag left review comments

@joshkellyjak joshkellyjak

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alecappiello @pcarruscag @joshkellyjak