◐ Shell
reader mode source ↗
Skip to content

Feature nemo tutorial#120

Open
jtneedels wants to merge 5 commits into
masterfrom
feature_nemo_tutorial
Open

Feature nemo tutorial#120
jtneedels wants to merge 5 commits into
masterfrom
feature_nemo_tutorial

Conversation

@jtneedels

@jtneedels jtneedels commented Jan 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adding NEMO tutorials, starting with inviscid wedge case. See addition of files to tutorial repo: su2code/Tutorials#37

@jtneedels
initial commit …
09cda9b 
Signed-off-by: jtneedels <jneedels@stanford.edu>
@jtneedels
adding invwedge tutorial …
c7d15f6 
Signed-off-by: jtneedels <jneedels@stanford.edu>
@pr-triage pr-triage Bot added the PR: draft label Jan 23, 2023
@jtneedels
remove ds store …
57e259a 
Signed-off-by: jtneedels <jneedels@stanford.edu>
@jtneedels
remove ds store …
7d4fe4d 
Signed-off-by: jtneedels <jneedels@stanford.edu>
@jtneedels jtneedels marked this pull request as ready for review January 23, 2023 19:49
@jtneedels jtneedels mentioned this pull request Jan 23, 2023
Open
@pcarruscag

pcarruscag commented Jan 23, 2023

Copy link
Copy Markdown
Member

You need to change the .yml files for the dropdown menus
https://github.com/su2code/su2code.github.io/pull/103/files

@jtneedels
adding change to yml …
6231d15 
Signed-off-by: jtneedels <jneedels@stanford.edu>
@jtneedels

jtneedels commented Jan 23, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @pcarruscag , PLTA, I think I addressed your comment above. Any other changes needed?

pcarruscag
pcarruscag approved these changes Jan 24, 2023
View reviewed changes

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, but if the links point to new files you may want to merge the other PRs first

@pcarruscag

pcarruscag commented Jan 24, 2023

Copy link
Copy Markdown
Member

It the files are all in master, then merge this to master instead, and you can directly check if everything is ok

@jtneedels

jtneedels commented Jan 26, 2023

Copy link
Copy Markdown
Contributor Author

Thanks Pedro, yeah links point to files that are being uploaded in a separate PR - I'll make sure that PR gets merged first then merge to master here.

@bigfooted

bigfooted commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

@jtneedels, are there still things to be done for this tutorial?

@jtneedels

jtneedels commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

@bigfooted Yeah, I think we actually want to switch to another test case for the tutorial - this case doesn't have great convergence.

Base automatically changed from develop to master August 30, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WallyMaier WallyMaier

@pcarruscag pcarruscag pcarruscag approved these changes

Assignees

No one assigned

Labels

PR: reviewed-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jtneedels @pcarruscag @bigfooted @WallyMaier