{{ message }}
Change Data.construct(from uint8Array:) return type from Data? to Data#752
Merged
kateinoigakukun merged 1 commit intoJun 1, 2026
Merged
Change Data.construct(from uint8Array:) return type from Data? to Data#752kateinoigakukun merged 1 commit into
kateinoigakukun merged 1 commit into
Conversation
Member
Sorry, something went wrong.
Hide details
View details
kateinoigakukun
merged commit
kateinoigakukun
merged commit d1e0f95
into
main
Jun 1, 2026
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Summary
Data.construct(from uint8Array:)return type fromData?toDataData.construct(from jsValue:)optional, since converting fromJSValuecan failRationale
Constructing from an already-typed
JSTypedArray<UInt8>cannot fail, so the optional return type is unnecessary.