{{ message }}
Journald GIL release#170
Open
ggoldber wants to merge 1 commit into
Open
Conversation
Sorry, something went wrong.
ggoldber
force-pushed
the
jourland_gil
branch
6 times, most recently
from
8eb400f to
0be4ebe
Compare
April 5, 2026 20:15
release gil before sending a log to journald and release afterwards Readme builder updates make wheel clean
behrmann
reviewed
Apr 6, 2026
Contributor
|
Thanks for the contribution! |
Sorry, something went wrong.
septatrix
reviewed
Jun 18, 2026
septatrix
left a comment
septatrix
left a comment
There was a problem hiding this comment.
I wonder what the advantages of putting this behind a compile flag are? As long as the implementation still upholds the same requirement (e.g. no cross-thread access to journal) I see no advantage of every keeping the GIL locked
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
When calling to sendv from journald handler, GIL is not released hence any issue with Journald causes every other thread to hang until the call is complete,