{{ message }}
Adding DDL trigger to speedup framework start#901
Merged
jgebal merged 17 commits intoJun 10, 2019
Merged
Conversation
Member
Sorry, something went wrong.
lwasylow
reviewed
Apr 12, 2019
lwasylow
reviewed
Apr 12, 2019
lwasylow
left a comment
lwasylow
left a comment
Member
There was a problem hiding this comment.
Looks really good. My only input would be, optional install and multi schema lots of devs working since trigger monitor full dB almost.
Sorry, something went wrong.
lwasylow
approved these changes
Apr 12, 2019
Some tests need to be fixed to disable trigger before testing Some tests need to be added to prove trigger is working
Disabled `-scc` flag in tests
jgebal
force-pushed
the
feature/cache_improvements
branch
from
11a2310 to
db8ef50
Compare
April 17, 2019 22:56
…r_for_annotations # Conflicts: # source/core/annotations/ut_annotation_manager.pkb # source/core/ut_suite_manager.pkb
Added disabling trigger on annotation parser tests.
Added additional tests for annotation management with / without trigger. Fixed code for situations when trigger gets added on pre-existing tests.
lwasylow
approved these changes
Jun 9, 2019
lwasylow
left a comment
lwasylow
left a comment
Member
There was a problem hiding this comment.
Code looks great, I have put some comment on small things but generally great job Jacek, running even faster will be awesome !
Sorry, something went wrong.
Refactored install scripts to avoid duplication. Added check for `oracle_maintained` schema when firing DDL trigger.
Reorganized code to avoid problems with conditional compilation on 12.2 for triggers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This PR adds support for DDL trigger to build annotation cache.
The approach is resolving huge schema scanning issues.
With this, users have option to install with or without DDL trigger enabled.
Without trigger, each time tests are run, framework needs to check cache validity. This can take quite some time on huge database schema.
With trigger enabled, no source code scanning is needed. Cache is maintained by DDL statements themselves.
Resolves #631