Issue 19561: request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

I'd like to have reopened this previous issue as it is still very much the case.

I believe as well that the common distros (I can easily verify OpenIndiana and OmniOS) patch it out (patch file attached). 
Upstream/oracle/userland-gate seems to as well.

It is time to retire this check, or at least take into consideration the parametrization from unistd.h:

#if defined(_XPG4_2)
extern int gethostname(char *, size_t);
#elif  !defined(__XOPEN_OR_POSIX) || defined(__EXTENSIONS__)
extern int gethostname(char *, int);
#endif

We have an OpenIndian buildbot that compiles from our source, so no distro changes.  Can you sort out why this isn't a problem on the buildbut but is for you?  Your patch files says 2.6, so is it possible it is fixed in 2.7?

I don't believe the problem is a question solely of building the python sources, but also certain dependent application sources... 

I know of at least libreoffice building against python and this problem has come up. 

The workaround was to apply the patch indicated (here, on python3.3).

Libreoffice is a big thing to compile as a test...do you know of any smaller packages that exhibit the bug?

I've added jcea to nosy, he set up the OpenIndiana buildbots and may be able to help clarify the issue.  I'm not willing to opine on it since I don't know what effect modifying those directives might have on other platforms.

Sure, attached is a simple test found on the internet, compiled with the following reproduces the problem:

richard@devzone:~/src$ /opt/local/gcc48/bin/g++ -o tp tp.cpp  -DSOLARIS -I/opt/local/include/python2.7 -L/opt/local/lib -lpython2.7 
In file included from /opt/local/include/python2.7/Python.h:58:0,
                 from tp.cpp:1:
/opt/local/include/python2.7/pyport.h:645:35: error: declaration of C function 'int gethostname(char*, int)' conflicts with
 extern int gethostname(char *, int);
                                   ^
In file included from /opt/local/include/python2.7/Python.h:44:0,
                 from tp.cpp:1:
/usr/include/unistd.h:351:12: error: previous declaration 'int gethostname(char*, uint_t)' here
 extern int gethostname(char *, size_t);

We (Solaris engineering) have hit this issue after migrating from 2.6
being our default version of Python to 2.7 being the default.  The
specific component that broke was vim (version 7.4), trying to compile
if_python.c:

"/usr/include/python2.7/pyport.h", line 645: identifier redeclared:
    gethostname                                                                          
        current : function(pointer to char, int) returning int                       
        previous: function(pointer to char, unsigned long) returning int :           
"/usr/include/unistd.h", line 412                                                    

We had this patched out in Python 2.6's Include/pyport.h:

-#ifdef SOLARIS
-/* Unchecked */
-extern int gethostname(char *, int);
-#endif

but for some reason that patch was not propagated to our 2.7 line.
Until today, that is; I will be applying that patch shortly to both
2.7 and 3.4.

I think this code should be removed.

It was added in its current form more than 20 years ago with the intention to add function declarations missing from system include files:
https://github.com/python/cpython/commit/1e0c2f4bee43728930bd5f4dc77283f09c4ba004

Today, every Solaris system should have gethostname() available in unistd.h. I am not sure when exactly was it added, but it was available in the OpenSolaris since the first commit (year 2005):
https://github.com/illumos/illumos-gate/blame/master/usr/src/head/unistd.h#L344


Also, AFAIK, 'SOLARIS' macro is not predefined on Solaris systems in compiler preprocessors today *; hence, unless compiled with `-DSOLARIS`, this code has no effect.

*) I tested this with several GCC [7|9|10] and Solaris studio and neither of those defined it. It seems like it might have worked many years ago, but it certainly isn't a way to #ifdef Solaris today.

And for the reference, Solaris distros are already removing this code:

https://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patch
https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patch
https://github.com/omniosorg/omnios-build/blob/master/build/python37/patches/15-gethostname.patch

messages: + msg202730

messages: + msg202723
nosy: + jcea