Issue 20363: BytesWarnings triggerred by test suite

[194/388] test_base64
/tmp/cpython/Lib/base64.py:365: BytesWarning: str() on a bytes instance
  "by {} and {}".format(_A85START, _A85END))
...
[204/388] test_hash
/tmp/cpython/Lib/test/test_hash.py:175: BytesWarning: str() on a bytes instance
  return 'print(hash(eval(%s.decode("utf-8"))))' % repr_.encode("utf-8")
...
[234/388] test_configparser
/tmp/cpython/Lib/configparser.py:289: BytesWarning: str() on a bytes instance
  Error.__init__(self, 'Source contains parsing errors: %s' % source)
/tmp/cpython/Lib/configparser.py:326: BytesWarning: str() on a bytes instance
  (filename, lineno, line))
...
[332/388/1] test_distutils
/tmp/cpython/Lib/distutils/command/register.py:303: BytesWarning: str() on a bytes instance
  self.announce('%s%s%s' % (dashes, data, dashes))

I think that repr could be used:
str(bytes_instance)    ->  repr(bytes_instance)
"%s" % bytes_instance  ->  "%r" % bytes_instance

Any opinions?

`repr(bytestr)[1:-1]` ;-)

You rather meant [2:-1] instead of [1:-1], but if initial "b'" and final "'" are not needed in result string, then maybe just call .decode() on an instance of bytes.

>>> str(b"xxx")
"b'xxx'"
>>> repr(b"xxx")
"b'xxx'"
>>> repr(b"xxx")[1:-1]
"'xxx"
>>> repr(b"xxx")[2:-1]
'xxx'
>>> b"xxx".decode()
'xxx'

> I think that repr could be used:

Agree.

"{}".format(bytestr) -> "{!r}".format(bytestr)

Here's a patch to silence BytesWarnings.

I think that %s is better for 'dashes' variable (which is always str) in Lib/distutils/command/register.py:
            self.announce('%s%r%s' % (dashes, data, dashes))

And

    'print(hash(eval(%s.decode("utf-8"))))' % repr_.encode("utf-8")

can be simplified to

    'print(hash(eval(%a)))' % repr_

Thanks for the review, Arfrever and Serhiy. Here's a new patch.

The new patch has %s and %r reversed in Lib/distutils/command/register.py.

Ah, my bad. Thanks Arfrever.

LGTM.

New changeset 791674a74e47 by Serhiy Storchaka in branch '3.3':
Issue #20363. Fixed BytesWarning triggerred by test suite.
http://hg.python.org/cpython/rev/791674a74e47

New changeset a4431dce107a by Serhiy Storchaka in branch 'default':
Issue #20363. Fixed BytesWarning triggerred by test suite.
http://hg.python.org/cpython/rev/a4431dce107a

Thank you Arfrever for your report. Thank you Berker for your patch.

Thanks for applying the patch.  distutils tests don’t cover 100% of the codebase; did you test manually that the behavior of the changed code was still correct?

At least it wasn't changed.

As I see, affected line is used to output debugging message (disabled by default). It produces different result in 2.7 and 3.x ("----------xxx----------" vs "----------b'xxx'----------") due to the difference between 2.x str and 3.x bytes.

I don’t understand one thing: you said the output wasn’t changed, then show an example of changed output: “"----------xxx----------" vs "----------b'xxx'----------"”.

The “data” that is displayed is supposed to be text; showing “b'” and “'” is a regression for the 3.x line.

Output is different between Python 2 and 3, but not different between different versions in Python 3.
Output in Python 3 is e.g. "----------b'xxx'----------" both before and after commit 791674a74e47.
I suggest to create a separate issue for discussion about this message in distutils.

Thanks for correcting me.  I created #20900.

messages: + msg213296

messages: + msg213292

stage: commit review -> resolved

messages: + msg209269

messages: + msg209263

type: behavior -> (no value)
assignee: lukasz.langa -> (no value)

keywords: + patch
nosy: + berker.peksag
messages: + msg209009
stage: needs patch -> (no value)