Issue 20556: Use specific asserts in threading tests
Created on 2014-02-07 21:34 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_threading_asserts.patch | serhiy.storchaka, 2014-02-07 21:34 | review | ||
| test_threading_asserts_2.patch | serhiy.storchaka, 2015-08-02 13:04 | review | ||
| Messages (9) | |||
|---|---|---|---|
| msg210562 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2014-02-07 21:34 | |
The proposed patch makes the threading module tests use more specific asserts. This will provide more useful failure report. |
|||
| msg237324 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2015-03-06 02:28 | |
Cut and paste error?
if verbose:
@@ -110,17 +110,17 @@
for t in threads:
t.join()
self.assertTrue(not t.is_alive())
+ self.assertFalse(t.is_alive())
|
|||
| msg237373 - (view) | Author: Demian Brecht (demian.brecht) *  |
Date: 2015-03-06 19:44 | |
LGTM |
|||
| msg247596 - (view) | Author: Robert Collins (rbcollins) * |
Date: 2015-07-29 18:24 | |
ping @serhiy - there's a bug in the patch. Moving back to patch review. |
|||
| msg247866 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-08-02 13:04 | |
Yes, I missed to remove one old assertion. Thanks Mark. |
|||
| msg258559 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2016-01-18 23:18 | |
test_threading_asserts_2.patch looks good to me. |
|||
| msg261717 - (view) | Author: Robert Collins (rbcollins) * |
Date: 2016-03-14 02:38 | |
@Serhiy care to commit it? |
|||
| msg261732 - (view) | Author: Roundup Robot (python-dev) |
Date: 2016-03-14 08:40 | |
New changeset 791d7ef006d3 by Serhiy Storchaka in branch '3.5': Issue #20556: Used specific assert methods in threading tests. https://hg.python.org/cpython/rev/791d7ef006d3 New changeset 9f8db4d1e149 by Serhiy Storchaka in branch '2.7': Issue #20556: Used specific assert methods in threading tests. https://hg.python.org/cpython/rev/9f8db4d1e149 New changeset b11acba0b785 by Serhiy Storchaka in branch 'default': Issue #20556: Used specific assert methods in threading tests. https://hg.python.org/cpython/rev/b11acba0b785 |
|||
| msg261733 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-03-14 08:42 | |
Thank you all for your reviews. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:58 | admin | set | github: 64755 |
| 2016-03-14 08:42:33 | serhiy.storchaka | set | status: open -> closed messages: + msg261733 assignee: serhiy.storchaka |
| 2016-03-14 08:40:45 | python-dev | set | nosy:
+ python-dev messages: + msg261732 |
| 2016-03-14 02:38:00 | rbcollins | set | messages: + msg261717 |
| 2016-01-18 23:18:53 | berker.peksag | set | versions:
- Python 3.4 nosy: + berker.peksag messages: + msg258559 stage: patch review -> commit review |
| 2015-08-02 13:04:41 | serhiy.storchaka | set | files:
+ test_threading_asserts_2.patch messages:
+ msg247866 |
| 2015-07-29 18:24:05 | rbcollins | set | nosy:
+ rbcollins messages:
+ msg247596 |
| 2015-03-06 19:44:07 | demian.brecht | set | nosy:
+ demian.brecht messages:
+ msg237373 |
| 2015-03-06 02:28:49 | BreamoreBoy | set | nosy:
+ BreamoreBoy messages: + msg237324 |
| 2014-02-07 21:36:36 | serhiy.storchaka | link | issue16510 dependencies |
| 2014-02-07 21:34:38 | serhiy.storchaka | create | |