Issue 30850: [2.7] bsddb3: test01_basic_replication() of test_bsddb3 fails randomly on AMD64 Windows8.1 Refleaks 2.7

See also bpo-30778: "test_bsddb3 crash on x86 Windows XP 2.7".

http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Refleaks%202.7/builds/40/steps/test/logs/stdio

1:07:30 [145/403/1] test_bsddb3 failed -- running: test_weakref (4038 sec), test_io (2487 sec), test_mmap (1406 sec)
test_bsddb3 still working, be patient...
  test_bsddb3 still working, be patient...
  test_bsddb3 still working, be patient...
Berkeley DB 4.7.25: (May 15, 2008)
Test path prefix:  d:\temp\z-test_bsddb3-5156
XXX: timeout happened beforestartup was confirmed - see issue 3892
test test_bsddb3 failed -- Traceback (most recent call last):
  File "D:\buildarea\2.7.ware-win81-release.refleak\build\lib\bsddb\test\test_replication.py", line 384, in test01_basic_replication
    self.assertTrue(time.time()<timeout)
AssertionError: False is not true

First at all replace self.assertTrue(time.time()<timeout) with self.assertLess(time.time(), timeout).

There was a large set of patches that did this globally for all tests (issue16510 and subissues), but it was mostly rejected (only some parts were merged, and often only into master).

"First at all replace self.assertTrue(time.time()<timeout) with
self.assertLess(time.time(), timeout). There was a large set of
patches that did this globally for all tests (issue16510 and
subissues), but it was mostly rejected (only some parts were merged,
and often only into master)."

Can you please propose a PR for that Serhiy, please?

> Can you please propose a PR for that Serhiy, please?

Will do.

New changeset 2b92cd3b16ba83aaaf11a91a19845ca6804663d9 by Victor Stinner (Serhiy Storchaka) in branch '2.7':
bpo-30850: Use specialized assert methods in bsddb tests. (#2584)
https://github.com/python/cpython/commit/2b92cd3b16ba83aaaf11a91a19845ca6804663d9

http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Refleaks%202.7/builds/50

...
test03_ThreadedTransactions (bsddb.test.test_thread.HashThreadedTransactions) ... ok
test03_ThreadedTransactions (bsddb.test.test_thread.BTreeThreadedNoWaitTransactions) ... ok
test03_ThreadedTransactions (bsddb.test.test_thread.HashThreadedNoWaitTransactions) ... ok
testCheckElapsedTime (test.test_bsddb3.TimingCheck) ... beginning 6 repetitions
123456
......
Berkeley DB 4.7.25: (May 15, 2008)
Test path prefix:  d:\temp\z-test_bsddb3-4292
XXX: timeout happened beforestartup was confirmed - see issue 3892
test test_bsddb3 failed -- Traceback (most recent call last):
  File "D:\buildarea\2.7.ware-win81-release.refleak\build\lib\bsddb\test\test_lock.py", line 132, in test04_lock_timeout2
    self.assertGreaterEqual(end_time-start_time, 0.0999)
AssertionError: 0.09599995613098145 not greater than or equal to 0.0999

ok

======================================================================
FAIL: test04_lock_timeout2 (bsddb.test.test_lock.LockingTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\buildarea\2.7.ware-win81-release.refleak\build\lib\bsddb\test\test_lock.py", line 132, in test04_lock_timeout2
    self.assertGreaterEqual(end_time-start_time, 0.0999)
AssertionError: 0.09599995613098145 not greater than or equal to 0.0999

x86 Windows XP 2.7:

http://buildbot.python.org/all/builders/x86%20Windows%20XP%202.7/builds/240/steps/test/logs/stdio

======================================================================
FAIL: test04_lock_timeout2 (bsddb.test.test_lock.LockingTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "d:\cygwin\home\db3l\buildarea\2.7.bolen-windows\build\lib\bsddb\test\test_lock.py", line 132, in test04_lock_timeout2
    self.assertGreaterEqual(end_time-start_time, 0.0999)
AssertionError: 0.05800008773803711 not greater than or equal to 0.0999

I wrote https://github.com/python/cpython/pull/2840 to tolerate only 50 ms on Windows, whereas 100 ms are expected (the test expects 99 ms or greater).

New changeset 0fc940a09ae6636e78f94ecf6436b8de14bd1c45 by Victor Stinner in branch '2.7':
test_bsddb3 tolerates smaller timeout on Windows (#2840)
https://github.com/python/cpython/commit/0fc940a09ae6636e78f94ecf6436b8de14bd1c45

The test fails randomly. Since I'm unable to reproduce the bug, I close the bug. (If the bug is not fixed, I will reopen the issue.)

Oh no, I saw it again!

http://buildbot.python.org/all/#/builders/51/builds/119/steps/3/logs/stdio

running: test_bsddb3 (1569 sec)
running: test_bsddb3 (1599 sec)
1:02:05 [403/403/1] test_bsddb3 crashed
(...)
1 test failed:
    test_bsddb3

stage: resolved