Issue 35876: test_start_new_session for posix_spawnp fails
Created on 2019-02-01 10:53 by pablogsal, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 11721 | merged | vstinner, 2019-02-01 11:17 | |
| PR 14093 | merged | miss-islington, 2019-06-14 17:32 | |
| Messages (6) | |||
|---|---|---|---|
| msg334664 - (view) | Author: Pablo Galindo Salgado (pablogsal) *  |
Date: 2019-02-01 10:53 | |
Example failure: https://buildbot.python.org/all/#/builders/141/builds/1142/steps/4/logs/stdio ===================================================================== ERROR: test_start_new_session (test.test_posix.TestPosixSpawn) ---------------------------------------------------------------------- Traceback (most recent call last): File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_posix.py", line 1640, in test_start_new_session child_pgid = int(output) NameError: name 'output' is not defined ====================================================================== ERROR: test_start_new_session (test.test_posix.TestPosixSpawnP) ---------------------------------------------------------------------- Traceback (most recent call last): File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_posix.py", line 1640, in test_start_new_session child_pgid = int(output) NameError: name 'output' is not defined ---------------------------------------------------------------------- Victor made a PR to ignore the test for now: https://github.com/python/cpython/pull/11718 This WIP PR intends to fix this bug: https://github.com/python/cpython/pull/11719 |
|||
| msg334666 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-02-01 10:56 | |
I skipped the test with commit 1e39b83f24ffade3e0ca1a8004b461354f64ae08. But the test still needs to be fixed. Joannah Nanjekye wrote the new test and I'm mentoring her, so I would prefer that she fix the test. |
|||
| msg334668 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-02-01 11:17 | |
> Joannah Nanjekye wrote the new test and I'm mentoring her, so I would prefer that she fix the test. Oh wait, when I looked at the test, it's way more complex to implement that what I expected! So I decided to rewrite the test myself. |
|||
| msg345618 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-06-14 17:31 | |
New changeset 5884043252473ac733aba1d3251d4debe72511e5 by Victor Stinner in branch 'master': bpo-35537: Rewrite setsid test for os.posix_spawn (GH-11721) https://github.com/python/cpython/commit/5884043252473ac733aba1d3251d4debe72511e5 |
|||
| msg345619 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-06-14 17:35 | |
I rewrote and reenabled the test. It should now be fixed in master, and the 3.8 backport is coming soon. |
|||
| msg345622 - (view) | Author: miss-islington (miss-islington) | Date: 2019-06-14 17:49 | |
New changeset e696b15a62dd0c85fe6ed3c9698b5f889c0bb1b3 by Miss Islington (bot) in branch '3.8': bpo-35537: Rewrite setsid test for os.posix_spawn (GH-11721) https://github.com/python/cpython/commit/e696b15a62dd0c85fe6ed3c9698b5f889c0bb1b3 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:10 | admin | set | github: 80057 |
| 2019-06-14 17:49:26 | miss-islington | set | nosy:
+ miss-islington messages: + msg345622 |
| 2019-06-14 17:35:33 | vstinner | set | status: open -> closed resolution: fixed messages: + msg345619 stage: patch review -> resolved |
| 2019-06-14 17:32:18 | miss-islington | set | pull_requests: + pull_request13948 |
| 2019-06-14 17:31:48 | vstinner | set | messages: + msg345618 |
| 2019-02-01 11:17:30 | vstinner | set | messages: + msg334668 |
| 2019-02-01 11:17:02 | vstinner | set | keywords:
+ patch stage: patch review pull_requests: + pull_request11597 |
| 2019-02-01 10:56:54 | vstinner | set | nosy:
+ nanjekyejoannah, vstinner messages: + msg334666 |
| 2019-02-01 10:53:19 | pablogsal | create | |