Issue 3751: str.rpartition fails silently with unicode argument
Created on 2008-09-01 15:09 by forest_atq, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| rpartition.patch | amaury.forgeotdarc, 2008-09-01 19:43 | |||
| Messages (6) | |||
|---|---|---|---|
| msg72259 - (view) | Author: Forest Bond (forest_atq) * | Date: 2008-09-01 15:09 | |
Python 2.5.2 (r252:60911, Jul 31 2008, 17:28:52) [GCC 4.2.3 (Ubuntu 4.2.3-2ubuntu7)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> u'/foo/bar'.rpartition(u'/') (u'/foo', u'/', u'bar') >>> '/foo/bar'.rpartition(u'/') (u'', u'/', u'foo/bar') |
|||
| msg72263 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) *  |
Date: 2008-09-01 15:20 | |
It's not failing, it's simply calling unicode.partition instead of unicode.rpartition! |
|||
| msg72264 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2008-09-01 15:33 | |
Adding a few tests wouldn't hurt :) |
|||
| msg72286 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * |
Date: 2008-09-01 19:43 | |
Updated patch, with tests. This is a 2.5 backport candidate. |
|||
| msg72287 - (view) | Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-09-01 19:47 | |
Go ahead with the patch and backporting; it looks fine to me. |
|||
| msg72289 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * |
Date: 2008-09-01 20:05 | |
Committed r66119 (trunk) and r66121 (python2.5) Thanks for the report! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:38 | admin | set | github: 48001 |
| 2008-09-01 20:05:34 | amaury.forgeotdarc | set | status: open -> closed resolution: fixed messages: + msg72289 |
| 2008-09-01 19:47:27 | benjamin.peterson | set | keywords:
- needs review nosy: + benjamin.peterson messages: + msg72287 |
| 2008-09-01 19:46:43 | amaury.forgeotdarc | set | files: - rpartition.patch |
| 2008-09-01 19:43:54 | amaury.forgeotdarc | set | keywords:
+ needs review files: + rpartition.patch messages: + msg72286 |
| 2008-09-01 15:33:24 | pitrou | set | nosy:
+ pitrou messages: + msg72264 |
| 2008-09-01 15:20:56 | amaury.forgeotdarc | set | files:
+ rpartition.patch keywords: + patch messages: + msg72263 nosy: + amaury.forgeotdarc |
| 2008-09-01 15:09:05 | forest_atq | create | |