Issue 40156: CodeCov/patch job stills runs on pull requests on 3.5 and 3.6 branches
Created on 2020-04-02 13:35 by vstinner, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 19306 | merged | vstinner, 2020-04-02 13:36 | |
| PR 19309 | merged | vstinner, 2020-04-02 17:55 | |
| Messages (7) | |||
|---|---|---|---|
| msg365594 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2020-04-02 13:35 | |
Larry Hastings (Python 3.5 release manager) failed to merge my security fix into Python 3.5. The Codecov job run on the PR, failed and it must pass to merge a PR if I understood correctly Larry: https://github.com/python/cpython/pull/17344#issuecomment-605417483 The same job also ran and failed on another security fix for Python 3.6: https://github.com/python/cpython/pull/19304 I propose to copy .github/codecov.yml configuration from master to 3.5 and 3.6 branches to disable the Codecov "patch" job. See also recent issue: bpo-39704 "Disable code coverage". Codecov should no longer post comments with the result of the code coverage analysis: it's disabled for the whole Python organization. There are no longer "Codecov patch" jobs on the 3.7, 3.8 and master branches. |
|||
| msg365606 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2020-04-02 17:29 | |
Here is my concrete solution for CodeCov issues on 3.5 and 3.6 branches. |
|||
| msg365607 - (view) | Author: Larry Hastings (larry) * |
Date: 2020-04-02 17:33 | |
I need to do a little more reading on it, but I expect if you make an equivalent PR for 3.5 I'll merge it. Thanks for taking this on, Victor! |
|||
| msg365612 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2020-04-02 18:02 | |
> I need to do a little more reading on it, but I expect if you make an equivalent PR for 3.5 I'll merge it. Thanks for taking this on, Victor! Done with PR 19309. |
|||
| msg365645 - (view) | Author: Larry Hastings (larry) * |
Date: 2020-04-02 23:10 | |
New changeset ed07522a5faa3101f68be8e4b8369310f60860f8 by Victor Stinner in branch '3.5': bpo-40156: Copy Codecov configuration from master (#19309) https://github.com/python/cpython/commit/ed07522a5faa3101f68be8e4b8369310f60860f8 |
|||
| msg365651 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2020-04-03 00:34 | |
New changeset ebeabb5b728f009480ced3ca4738c20fa073b507 by Victor Stinner in branch '3.6': bpo-40156: Copy Codecov configuration from master (GH-19306) https://github.com/python/cpython/commit/ebeabb5b728f009480ced3ca4738c20fa073b507 |
|||
| msg365659 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2020-04-03 00:59 | |
Thanks Ned and Larry. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:28 | admin | set | github: 84337 |
| 2020-04-03 00:59:24 | vstinner | set | status: open -> closed resolution: fixed messages: + msg365659 stage: patch review -> resolved |
| 2020-04-03 00:34:11 | ned.deily | set | messages: + msg365651 |
| 2020-04-02 23:10:05 | larry | set | messages: + msg365645 |
| 2020-04-02 18:02:03 | vstinner | set | messages: + msg365612 |
| 2020-04-02 17:55:10 | vstinner | set | pull_requests: + pull_request18672 |
| 2020-04-02 17:33:10 | larry | set | messages: + msg365607 |
| 2020-04-02 17:29:55 | vstinner | set | nosy:
+ larry, ned.deily messages: + msg365606 |
| 2020-04-02 13:38:20 | vstinner | set | title: codecov/patch stills runs on 3.5 and 3.6 branches -> CodeCov/patch job stills runs on pull requests on 3.5 and 3.6 branches |
| 2020-04-02 13:36:31 | vstinner | set | keywords:
+ patch stage: patch review pull_requests: + pull_request18668 |
| 2020-04-02 13:35:01 | vstinner | create | |