Issue 41938: concurrent.futures.wait calls len() on an possible iterable

Issue41938

Created on 2020-10-05 02:02 by rohitkg98, last changed 2022-04-11 14:59 by admin.

Pull Requests
URL	Status	Linked	Edit
PR 22555	open	rohitkg98, 2020-10-05 02:35

Messages (1)
msg377991 - (view)	Author: Kaushal Rohit (rohitkg98) *	Date: 2020-10-05 02:02
`fs` argument could be an iterable, and calling len on it would raise an Exception. We are converting `fs` into a set anyways for set difference, and that too twice. we can just put an `fs = set(fs)`. Let me know if we choose to go with that and I will make a PR ASAP. Thanks.

Messages (1)

msg377991 - (view)

Author: Kaushal Rohit (rohitkg98) *

Date: 2020-10-05 02:02

`fs` argument could be an iterable, and calling len on it would raise an Exception.

We are converting `fs` into a set anyways for set difference, and that too twice. we can just put an `fs = set(fs)`.

Let me know if we choose to go with that and I will make a PR ASAP.

Thanks.

History
Date	User	Action	Args
2022-04-11 14:59:36	admin	set	github: 86104
2020-10-05 02:35:35	rohitkg98	set	keywords: + patch stage: patch review pull_requests: + pull_request21553
2020-10-05 02:02:57	rohitkg98	create