Issue 43166: Unused letters in Windows-specific pragma optimize
Created on 2021-02-08 19:48 by gvanrossum, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 24485 | merged | steve.dower, 2021-02-09 18:13 | |
| PR 32023 | merged | neonene, 2022-03-21 07:09 | |
| Messages (4) | |||
|---|---|---|---|
| msg386646 - (view) | Author: Guido van Rossum (gvanrossum) *  |
Date: 2021-02-08 19:48 | |
A coworker happened to look at our use of #pragma optimize() for Windows (VS 2017) and noticed: unless there’s something I’m missing, the ‘a’ and ‘w’ portions of the string being passed to the optimize pragma are not doing anything; I’m pretty sure they’ve been useless for 10+ years. The ‘g’ means turn on global optimizations and the ‘t’ means optimize for “time” (i.e. speed). See the documentation at https://docs.microsoft.com/en-us/cpp/preprocessor/optimize?view=msvc-160 |
|||
| msg386735 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2021-02-09 18:14 | |
New changeset b74396c3167cc780f01309148db02709bc37b432 by Steve Dower in branch 'master': bpo-43166: Disable ceval.c optimisations for Windows debug builds (GH-24485) https://github.com/python/cpython/commit/b74396c3167cc780f01309148db02709bc37b432 |
|||
| msg387349 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2021-02-19 20:27 | |
Since this change, AMD64 Windows10 3.x buildbot started to crash with Windows fatal exception: stack overflow -> see bpo-43271. |
|||
| msg415843 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2022-03-23 00:35 | |
New changeset cd05d0a423d97be69f9de4650f68f89e99ad68d1 by neonene in branch 'main': bpo-43166: Disable ceval.c optimizations for Windows debug builds (GH-32023) https://github.com/python/cpython/commit/cd05d0a423d97be69f9de4650f68f89e99ad68d1 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:41 | admin | set | github: 87332 |
| 2022-03-23 00:35:32 | steve.dower | set | messages: + msg415843 |
| 2022-03-21 07:09:09 | neonene | set | nosy:
+ neonene pull_requests: + pull_request30111 |
| 2021-02-21 02:45:56 | db3l | set | nosy:
+ db3l |
| 2021-02-19 20:27:43 | vstinner | set | nosy:
+ vstinner messages: + msg387349 |
| 2021-02-09 18:14:19 | steve.dower | set | messages: + msg386735 |
| 2021-02-09 18:13:51 | steve.dower | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021-02-09 18:13:07 | steve.dower | set | keywords:
+ patch stage: patch review pull_requests: + pull_request23286 |
| 2021-02-08 19:49:55 | zach.ware | set | assignee: steve.dower components:
+ Windows |
| 2021-02-08 19:48:37 | gvanrossum | create | |