◐ Shell
clean mode source ↗

Issue 43920: OpenSSL 3.0.0: handle empty cadata consistently

classification
Title: OpenSSL 3.0.0: handle empty cadata consistently
Type: behavior Stage: resolved
Components: SSL Versions: Python 3.11, Python 3.10, Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: christian.heimes Nosy List: christian.heimes
Priority: normal Keywords: patch

Created on 2021-04-23 09:52 by christian.heimes, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 25554 merged christian.heimes, 2021-04-23 10:03
PR 25555 merged christian.heimes, 2021-04-23 11:53
PR 25556 merged christian.heimes, 2021-04-23 11:54
Messages (4)
msg391673 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-04-23 09:52 
OpenSSL 3.0.0-alpha15 handles empty data input to d2i_X509_bio() and PEM_read_bio_X509() differently. This causes cadata test for invalid data to fail with inconsistent error message.

Let's handle 0 result case more consistent and raise an error message that is more understandable than "no start line" or "not enough data".
msg391682 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-04-23 11:51 
New changeset b9ad88be0304136c3fe5959c65a5d2c75490cd80 by Christian Heimes in branch 'master':
bpo-43920: Make load_verify_locations(cadata) error message consistent (GH-25554)
https://github.com/python/cpython/commit/b9ad88be0304136c3fe5959c65a5d2c75490cd80
msg391689 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-04-23 12:23 
New changeset e259a77f21bdfc7d4195913b379cbd6daee45d0d by Christian Heimes in branch '3.9':
[3.9] bpo-43920: Make load_verify_locations(cadata) error message consistent (GH-25554) (GH-25555)
https://github.com/python/cpython/commit/e259a77f21bdfc7d4195913b379cbd6daee45d0d
msg391699 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-04-23 14:37 
New changeset 82b6c0909aae423d9c8f4ff7d0e8df16106dbe28 by Christian Heimes in branch '3.8':
[3.8] bpo-43920: Make load_verify_locations(cadata) error message consistent (GH-25554) (GH-25556)
https://github.com/python/cpython/commit/82b6c0909aae423d9c8f4ff7d0e8df16106dbe28
History
Date User Action Args
2022-04-11 14:59:44adminsetgithub: 88086
2021-04-23 14:37:43christian.heimessetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-04-23 14:37:16christian.heimessetmessages: + msg391699
2021-04-23 12:23:40christian.heimessetmessages: + msg391689
2021-04-23 11:54:52christian.heimessetpull_requests: + pull_request24276
2021-04-23 11:53:57christian.heimessetpull_requests: + pull_request24275
2021-04-23 11:51:44christian.heimessetmessages: + msg391682
2021-04-23 11:44:32christian.heimeslinkissue38820 dependencies
2021-04-23 10:03:27christian.heimessetkeywords: + patch
stage: patch review
pull_requests: + pull_request24274
2021-04-23 09:52:47christian.heimescreate