Issue 45578: Missing tests for the dis module
Created on 2021-10-22 18:15 by nanjekyejoannah, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 29332 | merged | sobolevn, 2021-10-30 16:01 | |
| PR 29385 | merged | lukasz.langa, 2021-11-03 14:10 | |
| PR 29386 | merged | lukasz.langa, 2021-11-03 14:14 | |
| PR 30058 | merged | sobolevn, 2021-12-11 16:15 | |
| Messages (12) | |||
|---|---|---|---|
| msg404805 - (view) | Author: Joannah Nanjekye (nanjekyejoannah) *  |
Date: 2021-10-22 18:15 | |
I don't see any tests for the following: dis.distb dis.findlabels They are documented, I wonder if it was intentional. dis.findlabels is also not dicumented. |
|||
| msg404809 - (view) | Author: Joannah Nanjekye (nanjekyejoannah) * |
Date: 2021-10-22 18:29 | |
maybe the latter is not a public function. |
|||
| msg404811 - (view) | Author: Joannah Nanjekye (nanjekyejoannah) * |
Date: 2021-10-22 18:30 | |
It looks like it actually |
|||
| msg405370 - (view) | Author: Nikita Sobolev (sobolevn) *  |
Date: 2021-10-30 15:33 | |
I would like to work on it! :) Going to send a PR today. |
|||
| msg405373 - (view) | Author: Nikita Sobolev (sobolevn) * |
Date: 2021-10-30 16:41 | |
Looks like `findlabels` is documented: https://docs.python.org/3/library/dis.html#dis.findlabels |
|||
| msg405374 - (view) | Author: Joannah Nanjekye (nanjekyejoannah) * |
Date: 2021-10-30 16:51 | |
Yes, it is that's why I added the clarity "It looks like it *is* actually" above |
|||
| msg405618 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-11-03 13:55 | |
New changeset e346f196819aeb02a8a94205ce3e1536c4c2f105 by Nikita Sobolev in branch 'main': bpo-45578: add tests for `dis.distb` (GH-29332) https://github.com/python/cpython/commit/e346f196819aeb02a8a94205ce3e1536c4c2f105 |
|||
| msg405622 - (view) | Author: Nikita Sobolev (sobolevn) * |
Date: 2021-11-03 15:07 | |
Only `findlabels` tests are left! |
|||
| msg405625 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-11-03 15:53 | |
New changeset fd6b70d6b715c2403a194a2b3eae3210e2e81742 by Łukasz Langa in branch '3.10': [3.10] bpo-45578: add tests for `dis.distb` (GH-29332) (GH-29385) https://github.com/python/cpython/commit/fd6b70d6b715c2403a194a2b3eae3210e2e81742 |
|||
| msg405631 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-11-03 16:47 | |
New changeset 8198617bcce885c280ba5f8acd066c71b311b1ac by Łukasz Langa in branch '3.9': [3.9] bpo-45578: add tests for `dis.distb` (GH-29332) (#29386) https://github.com/python/cpython/commit/8198617bcce885c280ba5f8acd066c71b311b1ac |
|||
| msg411726 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2022-01-26 10:05 | |
New changeset 84f093918a4be663775afe2933f4be86f72fe495 by Nikita Sobolev in branch 'main': bpo-45578: add a test case for `dis.findlabels` (GH-30058) https://github.com/python/cpython/commit/84f093918a4be663775afe2933f4be86f72fe495 |
|||
| msg411745 - (view) | Author: Tal Einat (taleinat) * |
Date: 2022-01-26 12:39 | |
Thanks for your work on this Nikita! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:51 | admin | set | github: 89741 |
| 2022-01-26 12:39:55 | taleinat | set | status: open -> closed nosy:
+ taleinat resolution: fixed |
| 2022-01-26 10:05:56 | corona10 | set | nosy:
+ corona10 messages: + msg411726 |
| 2021-12-11 16:15:38 | sobolevn | set | pull_requests: + pull_request28278 |
| 2021-11-03 16:47:12 | lukasz.langa | set | messages: + msg405631 |
| 2021-11-03 15:53:53 | lukasz.langa | set | messages: + msg405625 |
| 2021-11-03 15:07:08 | sobolevn | set | messages: + msg405622 |
| 2021-11-03 14:14:45 | lukasz.langa | set | pull_requests: + pull_request27644 |
| 2021-11-03 14:10:47 | lukasz.langa | set | pull_requests: + pull_request27643 |
| 2021-11-03 13:55:47 | lukasz.langa | set | nosy:
+ lukasz.langa messages: + msg405618 |
| 2021-10-30 16:51:18 | nanjekyejoannah | set | messages: + msg405374 |
| 2021-10-30 16:41:09 | sobolevn | set | messages: + msg405373 |
| 2021-10-30 16:01:48 | sobolevn | set | keywords:
+ patch stage: patch review pull_requests: + pull_request27600 |
| 2021-10-30 15:33:01 | sobolevn | set | nosy:
+ sobolevn messages: + msg405370 |
| 2021-10-22 18:30:18 | nanjekyejoannah | set | messages: + msg404811 |
| 2021-10-22 18:29:32 | nanjekyejoannah | set | messages: + msg404809 |
| 2021-10-22 18:16:15 | nanjekyejoannah | set | title: Missing tests for he dis module -> Missing tests for the dis module |
| 2021-10-22 18:15:58 | nanjekyejoannah | create | |