Issue 5236: time.strptime should reject bytes arguments on Py3

On Python3 time.strptime(string[, format]) accepts bytes as arguments
and then fails:

>>> strptime(b"2009", "%Y")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Programs\Python30\lib\_strptime.py", line 454, in _strptime_time
    return _strptime(data_string, format)[0]
  File "C:\Programs\Python30\lib\_strptime.py", line 322, in _strptime
    found = format_regex.match(data_string)
TypeError: can't use a string pattern on a bytes-like object

time.strftime already rejects bytes arguments:
>>> strftime(b'%Y')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: strftime() argument 1 must be str, not bytes

time.strptime should do the same and reject bytes for both the arguments
(string and format).

(With Py2.x both str and unicode args work.)

I believe this shouldn't be tagged as part of the Lib component...

Also, I am happy to work on this issue, developing tests and a patch.
Would that be appropriate? I may take a little while to get the hang of
things, but I'm happy to put some time into this.

My mistake, it is part of the Lib component ... I failed to see the
callback to Python from timemodule.c and jumped to conclusions.

In any case, I'm happy to work on this.

See also thread
http://mail.python.org/pipermail/python-dev/2009-March/087104.html

If you want to work on it, Tennesse, then go for it!

Python implementation to raise this exception if a bytes argument is
passed in as argument 1.

Test case added to test_time

Please remove the whitespace changes in the patch 
(around "_cache_lock"). Otherwise it is good.

Thanks for the comments all and sorry for the delay -- life!

I am going to do a review at http://codereview.appspot.com/28147 ; not
done yet.

Applied in r70755 for py3k. I am not backporting as I changed it to
explicitly check both arguments which is a change in semantics.

versions: - Python 3.0

messages: + msg83506

messages: + msg83488
components: + Library (Lib), - Extension Modules