Issue 8522: enhacement proposal in howto/doanddont

Hi, in "Exceptions" section. 

Instead of using:

def get_status(file):
    fp = open(file)
    try:
        return fp.readline()
    finally:
        fp.close()

Why no suggest this method:

def get_status(file):
    with open(file) as fp:
	return fp.readline()


which will properly close the file.

Hello

You’re right, this idiom (new in 2.5, always enabled in 2.6) is now the recommended way of doing this. Note that the older code does close the file properly too, it’s just another way of doing it.

Would you like to provide a patch against the latest version of this file?
 
Regards

Hi, you are right. I am attaching the patch. I tested against 2.6.5 and trunk (the file has no changed)

thanks

Thanks, applied in r80461.

nosy: + georg.brandl
messages: + msg104146

resolution: fixed

title: enhacement proposal in http://docs.python.org/howto/doanddont.html -> enhacement proposal in howto/doanddont
nosy: + eric.araujo
versions: + Python 3.1, Python 2.7, Python 3.2
messages: + msg104112
stage: needs patch