Issue 9797: wrong assumption in pystate.c
Issue9797
Created on 2010-09-08 11:11 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| autotlskey.patch | pitrou, 2010-09-08 11:11 | |||
| autotlskey2.patch | pitrou, 2010-09-08 11:57 | |||
| Messages (4) | |||
|---|---|---|---|
| msg115858 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2010-09-08 11:11 | |
pystate.c assumes that when autoTLSkey is 0, it hasn't been created yet. However, some TLS implementations can return 0 as a valid key value. Lots of interesting things then happen. Here is a patch. |
|||
| msg115860 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * |
Date: 2010-09-08 11:49 | |
Couldn't the patch use autoInterpreterState instead? It is already modified at the same times as autoTLSkey. |
|||
| msg115861 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2010-09-08 11:57 | |
Ok, it is simpler indeed. Here is an updated patch. |
|||
| msg115866 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2010-09-08 12:49 | |
Committed in r84623 (3.x), r84627 (2.7) and r84628 (3.1). |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:06 | admin | set | github: 54006 |
| 2010-09-08 12:49:23 | pitrou | set | status: open -> closed resolution: fixed messages: + msg115866 stage: patch review -> resolved |
| 2010-09-08 11:57:00 | pitrou | set | files:
+ autotlskey2.patch messages: + msg115861 |
| 2010-09-08 11:49:04 | amaury.forgeotdarc | set | messages: + msg115860 |
| 2010-09-08 11:12:37 | pitrou | link | issue9786 dependencies |
| 2010-09-08 11:11:20 | pitrou | create | |