Message 122987 - Python tracker

Message122987

Author	pitrou
Recipients	catlee, davide.rizzo, eric.araujo, georg.brandl, jhylton, orsenthil, pitrou, rcoyner, rhettinger, xuanji
Date	2010-12-01.10:06:23
SpamBayes Score	6.293408e-05
Marked as misclassified	No
Message-id	<1291197985.58.0.52800759882.issue3243@psf.upfronthosting.co.za>
In-reply-to

Content
Senthil: + try: + self.sock.sendall(data) Indentation problem here. + if isinstance(data,str): + content_length = len(data) I'm not sure I understand. What does sending an unicode string mean? + # Check iterable body support + def iterable_body(): + yield "one" + yield "two" + yield "three" Iterables of strings? this doesn't seem supported in the patch. Also, it would be nice if the tests checked that the sent data is as expected.

Content

Senthil:

+        try:
+           self.sock.sendall(data)

Indentation problem here.

+                if isinstance(data,str):
+                    content_length = len(data)

I'm not sure I understand. What does sending an unicode string mean?

+        # Check iterable body support
+        def iterable_body():
+            yield "one"
+            yield "two"
+            yield "three"

Iterables of strings? this doesn't seem supported in the patch.

Also, it would be nice if the tests checked that the sent data is as expected.

History
Date	User	Action	Args
2010-12-01 10:06:25	pitrou	set	recipients: + pitrou, jhylton, georg.brandl, rhettinger, orsenthil, catlee, eric.araujo, rcoyner, xuanji, davide.rizzo
2010-12-01 10:06:25	pitrou	set	messageid: <1291197985.58.0.52800759882.issue3243@psf.upfronthosting.co.za>
2010-12-01 10:06:24	pitrou	link	issue3243 messages
2010-12-01 10:06:23	pitrou	create