Message 186823 - Python tracker

Message186823

Author	pitrou
Recipients	alexandre.vassalotti, pitrou, serhiy.storchaka, vstinner
Date	2013-04-13.20:20:36
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1365884436.93.0.41948759373.issue17710@psf.upfronthosting.co.za>
In-reply-to

Content
Alexandre, I don't like your patch very much: - you are changing the exception from ValueError to UnpicklingError (which doesn't derive from ValueError) in a bugfix release - you aren't actually adding any guards in the C code, so it's not demonstrably more robust

Content

Alexandre, I don't like your patch very much:
- you are changing the exception from ValueError to UnpicklingError (which doesn't derive from ValueError) in a bugfix release
- you aren't actually adding any guards in the C code, so it's not demonstrably more robust

History
Date	User	Action	Args
2013-04-13 20:20:37	pitrou	set	recipients: + pitrou, vstinner, alexandre.vassalotti, serhiy.storchaka
2013-04-13 20:20:36	pitrou	set	messageid: <1365884436.93.0.41948759373.issue17710@psf.upfronthosting.co.za>
2013-04-13 20:20:36	pitrou	link	issue17710 messages
2013-04-13 20:20:36	pitrou	create