Message 186836 - Python tracker

Message186836

Author	alexandre.vassalotti
Recipients	alexandre.vassalotti, pitrou, serhiy.storchaka, vstinner
Date	2013-04-13.20:42:10
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1365885730.56.0.715801588004.issue17710@psf.upfronthosting.co.za>
In-reply-to

Content
I was targeting head, not the release branches. It is fine to change the exception there as we don't make any guarantee about the exceptions raised during the unpickling process. It is easy enough to fix patch use ValueError for the release branch. And adding guards is unnecessary after the removing the code for stripping trailing whitespace. Here's slightly updated patch that check if readline() reached an EOF instead of a newline.

Content

I was targeting head, not the release branches. It is fine to change the exception there as we don't make any guarantee about the exceptions raised during the unpickling process. It is easy enough to fix patch use ValueError for the release branch.

And adding guards is unnecessary after the removing the code for stripping trailing whitespace.

Here's slightly updated patch that check if readline() reached an EOF instead of a newline.

History
Date	User	Action	Args
2013-04-13 20:42:10	alexandre.vassalotti	set	recipients: + alexandre.vassalotti, pitrou, vstinner, serhiy.storchaka
2013-04-13 20:42:10	alexandre.vassalotti	set	messageid: <1365885730.56.0.715801588004.issue17710@psf.upfronthosting.co.za>
2013-04-13 20:42:10	alexandre.vassalotti	link	issue17710 messages
2013-04-13 20:42:10	alexandre.vassalotti	create