Message 200938 - Python tracker

Message200938

Author	ncoghlan
Recipients	christian.heimes, jcea, leim, macfreek, ncoghlan, pmoody, python-dev, santoso.wijaya, terry.reedy
Date	2013-10-22.12:52:43
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1382446363.37.0.387438076732.issue17400@psf.upfronthosting.co.za>
In-reply-to

Content
The docs patch doesn't look quite right - Peter, did you mean to copy the "is_private" docs before modifying them? As far as caching goes, perhaps we can just drop functools.lru_cache into the relevant property implementations? @property @lru_cache() def is_global(self): """Test if this address is allocated for public networks.""" (also in copying that example method header, I noticed the docstring for the IPv4 is_global currently still says "private" instead of "public")

Content

The docs patch doesn't look quite right - Peter, did you mean to copy the "is_private" docs before modifying them?

As far as caching goes, perhaps we can just drop functools.lru_cache into the relevant property implementations?

    @property
    @lru_cache()
    def is_global(self):
        """Test if this address is allocated for public networks."""

(also in copying that example method header, I noticed the docstring for the IPv4 is_global currently still says "private" instead of "public")

History
Date	User	Action	Args
2013-10-22 12:52:43	ncoghlan	set	recipients: + ncoghlan, terry.reedy, jcea, macfreek, christian.heimes, pmoody, santoso.wijaya, python-dev, leim
2013-10-22 12:52:43	ncoghlan	set	messageid: <1382446363.37.0.387438076732.issue17400@psf.upfronthosting.co.za>
2013-10-22 12:52:43	ncoghlan	link	issue17400 messages
2013-10-22 12:52:43	ncoghlan	create