Message 216640 - Python tracker

Message216640

Author	vstinner
Recipients	matrixise, pitrou, rhettinger, vstinner
Date	2014-04-17.02:05:52
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1397700352.43.0.00738358808842.issue21259@psf.upfronthosting.co.za>
In-reply-to

Content
I reviewed issue21259-replace_except_pass-2.patch. Please split this huge patch into smaller patches: 1) remove dummy "except: raise" 2) use os.unlink() 3) replace "except: pass" with more precise exceptions like "except OSError:" => please write multiple small patches for this part 4) generic change "except: pass" to "except Exception: pass" You might open a new issue for these 4 kind of patches (4 issues).

Content

I reviewed  issue21259-replace_except_pass-2.patch. Please split this huge patch into smaller patches:

1) remove dummy "except: raise"
2) use os.unlink()
3) replace "except: pass" with more precise exceptions like "except OSError:" => please write multiple small patches for this part
4) generic change "except: pass" to "except Exception: pass"

You might open a new issue for these 4 kind of patches (4 issues).

History
Date	User	Action	Args
2014-04-17 02:05:52	vstinner	set	recipients: + vstinner, rhettinger, pitrou, matrixise
2014-04-17 02:05:52	vstinner	set	messageid: <1397700352.43.0.00738358808842.issue21259@psf.upfronthosting.co.za>
2014-04-17 02:05:52	vstinner	link	issue21259 messages
2014-04-17 02:05:52	vstinner	create