Message 217910 - Python tracker

Message217910

Author	lemburg
Recipients	Christian.Clauss, Justin.Cappos, jackdied, lemburg, math_foo, ronaldoussoren
Date	2014-05-05.07:48:00
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1399276081.41.0.310525036648.issue7850@psf.upfronthosting.co.za>
In-reply-to

Content
Caelyn: Thanks for the patch. Some comments: * Please use aliased=False instead of aliased=0 in the patch. * It would be great if you could enhance the test a bit to actually check the return value. This would need a mock of the os.uname API for the test. * Doc string "if "aliased" is true" should read "If aliased is true"

Content

Caelyn: Thanks for the patch.

Some comments:

* Please use aliased=False instead of aliased=0 in the patch.
* It would be great if you could enhance the test a bit to actually check the return value. This would need a mock of the os.uname API for the test.
* Doc string "if "aliased" is true" should read "If aliased is true"

History
Date	User	Action	Args
2014-05-05 07:48:01	lemburg	set	recipients: + lemburg, ronaldoussoren, jackdied, Justin.Cappos, Christian.Clauss, math_foo
2014-05-05 07:48:01	lemburg	set	messageid: <1399276081.41.0.310525036648.issue7850@psf.upfronthosting.co.za>
2014-05-05 07:48:01	lemburg	link	issue7850 messages
2014-05-05 07:48:00	lemburg	create