"I don't think we should be using PyMODINIT_FUNC for builtin modules, since that will make the init functions publicly available from python35.dll."
Do you mean that my change on PC/config.c is wrong?
For example, Modules/arraymodule.c already contains:
"PyMODINIT_FUNC PyInit_array(void)".
Is the PyInit_array symbol exported today or not on Windows?
If you think that the PyInit_array symbol should be private, maybe there is already an issue in Modules/arraymodule.c?
"can we define PyMODINIT_FUNC differently when building pythoncore?"
We can add a different macro for builtin modules. Using the issue #11410, we may use it to hide the symbols: __attribute__((visibility("hidden"))).