Message 257276 - Python tracker

Message257276

Author	martin.panter
Recipients	abarnert, abarry, curioswati, gvanrossum, martin.panter, ncoghlan, r.david.murray, rhettinger, serhiy.storchaka, terry.reedy
Date	2016-01-01.05:32:55
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1451626376.23.0.20897611726.issue25864@psf.upfronthosting.co.za>
In-reply-to

Content
If this patch goes ahead, I think the ABC documentation should clarify which methods are checked for None and which aren’t. The datamodel.rst file will suggest None for any method, but ABC will only support it for Iterable and Hashable (I think). Also, what is the point of the odd __getitem__() method in test_enumerate.py? Maybe you should use assertRaisesRegex() to check that the intended TypeError is actually raised.

Content

If this patch goes ahead, I think the ABC documentation should clarify which methods are checked for None and which aren’t. The datamodel.rst file will suggest None for any method, but ABC will only support it for Iterable and Hashable (I think).

Also, what is the point of the odd __getitem__() method in test_enumerate.py? Maybe you should use assertRaisesRegex() to check that the intended TypeError is actually raised.

History
Date	User	Action	Args
2016-01-01 05:32:56	martin.panter	set	recipients: + martin.panter, gvanrossum, rhettinger, terry.reedy, ncoghlan, r.david.murray, serhiy.storchaka, abarnert, abarry, curioswati
2016-01-01 05:32:56	martin.panter	set	messageid: <1451626376.23.0.20897611726.issue25864@psf.upfronthosting.co.za>
2016-01-01 05:32:56	martin.panter	link	issue25864 messages
2016-01-01 05:32:55	martin.panter	create