Message 266984 - Python tracker

Message266984

Author	JelleZijlstra
Recipients	JelleZijlstra, brett.cannon, buchuki, ethan.furman, python-dev, serhiy.storchaka
Date	2016-06-02.23:17:22
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1464909442.95.0.140318629954.issue27186@psf.upfronthosting.co.za>
In-reply-to

Content
This patch adds the C implementation (copied from the PEP). Some notes: - I added a new .h file in Include/ because there didn't seem to be an obvious existing place to put it. - There was some uncertainty about whether we should Py_INCREF the string or bytes returned when a string/bytes is passed in. Running test -l and -L works with the Py_INCREF in and we're adding a new reference to the module, so I think this is correct.

Content

This patch adds the C implementation (copied from the PEP).

Some notes:
- I added a new .h file in Include/ because there didn't seem to be an obvious existing place to put it.
- There was some uncertainty about whether we should Py_INCREF the string or bytes returned when a string/bytes is passed in. Running test -l and -L works with the Py_INCREF in and we're adding a new reference to the module, so I think this is correct.

History
Date	User	Action	Args
2016-06-02 23:17:23	JelleZijlstra	set	recipients: + JelleZijlstra, brett.cannon, ethan.furman, python-dev, serhiy.storchaka, buchuki
2016-06-02 23:17:22	JelleZijlstra	set	messageid: <1464909442.95.0.140318629954.issue27186@psf.upfronthosting.co.za>
2016-06-02 23:17:22	JelleZijlstra	link	issue27186 messages
2016-06-02 23:17:22	JelleZijlstra	create