Message 284089 - Python tracker

Message284089

Author	berker.peksag
Recipients	berker.peksag, gentoo90, loewis, steve.dower, tim.golden, xoviat, zach.ware
Date	2016-12-27.12:27:13
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1482841634.16.0.316245819128.issue20486@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for the patch, 12345. Steve knows better, but I think the method should be named "Close" instead of "close" like _msi.View's Close method. Also, I couldn't apply your patch: $ hg imp http://bugs.python.org/file45971/Add_ability_to_close_MSI_database_.patch applying http://bugs.python.org/file45971/Add_ability_to_close_MSI_database_.patch unable to find '_msi.c' for patching patching file _msi.c 2 out of 2 hunks FAILED -- saving rejects to file _msi.c.rej abort: patch failed to apply You may want to read https://docs.python.org/devguide/patch.html for details about creating a patch.

Content

Thanks for the patch, 12345. Steve knows better, but I think the method should be named "Close" instead of "close" like _msi.View's Close method.

Also, I couldn't apply your patch:

$ hg imp http://bugs.python.org/file45971/Add_ability_to_close_MSI_database_.patch
applying http://bugs.python.org/file45971/Add_ability_to_close_MSI_database_.patch
unable to find '_msi.c' for patching
patching file _msi.c
2 out of 2 hunks FAILED -- saving rejects to file _msi.c.rej
abort: patch failed to apply

You may want to read https://docs.python.org/devguide/patch.html for details about creating a patch.

History
Date	User	Action	Args
2016-12-27 12:27:14	berker.peksag	set	recipients: + berker.peksag, loewis, tim.golden, zach.ware, steve.dower, gentoo90, xoviat
2016-12-27 12:27:14	berker.peksag	set	messageid: <1482841634.16.0.316245819128.issue20486@psf.upfronthosting.co.za>
2016-12-27 12:27:14	berker.peksag	link	issue20486 messages
2016-12-27 12:27:13	berker.peksag	create