Message 301394 - Python tracker

Message301394

Author	vstinner
Recipients	barry, pitrou, rhettinger, serhiy.storchaka, skrah, vstinner
Date	2017-09-05.23:06:48
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1504652808.78.0.754827617442.issue31338@psf.upfronthosting.co.za>
In-reply-to

Content
+#define Py_UNREACHABLE() abort() Using such macro, I don't think that __builtin_unreachable() is useful. https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html Another use for __builtin_unreachable is following a call a function that never returns but that is not declared __attribute__((noreturn)), as in this example: (...) function_that_never_returns (); __builtin_unreachable (); I expect abort() to be annotated with __attribute__((noreturn)) on the C library used GCC.

Content

+#define Py_UNREACHABLE() abort()

Using such macro, I don't think that __builtin_unreachable() is useful.

https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html

Another use for __builtin_unreachable is following a call a function that never returns but that is not declared __attribute__((noreturn)), as in this example: 

      (...)
      function_that_never_returns ();
      __builtin_unreachable ();

I expect abort() to be annotated with __attribute__((noreturn)) on the C library used GCC.

History
Date	User	Action	Args
2017-09-05 23:06:48	vstinner	set	recipients: + vstinner, barry, rhettinger, pitrou, skrah, serhiy.storchaka
2017-09-05 23:06:48	vstinner	set	messageid: <1504652808.78.0.754827617442.issue31338@psf.upfronthosting.co.za>
2017-09-05 23:06:48	vstinner	link	issue31338 messages
2017-09-05 23:06:48	vstinner	create