Message 319594 - Python tracker

Message319594

Author	serhiy.storchaka
Recipients	alex, cstratak, pablogsal, serhiy.storchaka, vstinner, xiang.zhang
Date	2018-06-15.08:23:25
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1529051005.94.0.947875510639.issue33630@psf.upfronthosting.co.za>
In-reply-to

Content
As I wrote on GitHub, I think that it is better to use the list approach always for two reasons: 1) Additional #if's and duplications clutter the code. 2) It is hard to test the alternate branch if the other branch is used on most developer computers. It is better to have a single branch and add a comment that explains a workaround. It can be removed after platforms with buggy glibc versions will grow out of use.

Content

As I wrote on GitHub, I think that it is better to use the list approach always for two reasons:

1) Additional #if's and duplications clutter the code.

2) It is hard to test the alternate branch if the other branch is used on most developer computers.

It is better to have a single branch and add a comment that explains a workaround. It can be removed after platforms with buggy glibc versions will grow out of use.

History
Date	User	Action	Args
2018-06-15 08:23:26	serhiy.storchaka	set	recipients: + serhiy.storchaka, vstinner, alex, xiang.zhang, cstratak, pablogsal
2018-06-15 08:23:25	serhiy.storchaka	set	messageid: <1529051005.94.0.947875510639.issue33630@psf.upfronthosting.co.za>
2018-06-15 08:23:25	serhiy.storchaka	link	issue33630 messages
2018-06-15 08:23:25	serhiy.storchaka	create