> The patch does not use the version information passed in to calculate the marketing version. That's a problem when passing in low-level information from a system running a different version of macOS (for example passing in the low-level version information from a macOS 10.8 system while the script is running on a macOS 10.14 system).
Right. The function has a weird API. Maybe the function shouldn't be fixed in this case. If we don't fix it, I would like to at least document why the function doesn't replace Darwin with macOS.