Message 342470 - Python tracker

Message342470

Author	vstinner
Recipients	cstratak, gregory.p.smith, martin.panter, miss-islington, orange, serhiy.storchaka, vstinner, ware, xiang.zhang, xtreak
Date	2019-05-14.15:09:30
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1557846570.22.0.995458203195.issue30458@roundup.psfhosted.org>
In-reply-to

Content
I backported the fix from Python 3.7 to Python 2.7: PR 13315. Please review it carefully, I had to make multiple changes to adapt the fix to Python 2: * non-ASCII characters are explicitly rejected * urllib doesn't reject control characters: they are quoted properly, so I addapted test_urllib * urllib2 doesn't quote the URL and so reject control characters, I added tests to test_urllib2 * I replaced http.client with httplib * I replaced urllib.request with urllib or urllib2

Content

I backported the fix from Python 3.7 to Python 2.7: PR 13315.

Please review it carefully, I had to make multiple changes to adapt the fix to Python 2:

* non-ASCII characters are explicitly rejected
* urllib doesn't reject control characters: they are quoted properly, so I addapted test_urllib
* urllib2 doesn't quote the URL and so reject control characters, I added tests to test_urllib2
* I replaced http.client with httplib
* I replaced urllib.request with urllib or urllib2

History
Date	User	Action	Args
2019-05-14 15:09:30	vstinner	set	recipients: + vstinner, gregory.p.smith, martin.panter, serhiy.storchaka, xiang.zhang, cstratak, orange, miss-islington, xtreak, ware
2019-05-14 15:09:30	vstinner	set	messageid: <1557846570.22.0.995458203195.issue30458@roundup.psfhosted.org>
2019-05-14 15:09:30	vstinner	link	issue30458 messages
2019-05-14 15:09:30	vstinner	create