Message 366094 - Python tracker

Message366094

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	vstinner
Date	2020-04-10.00:18:58
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1586477939.23.0.270435463457.issue40241@roundup.psfhosted.org>
In-reply-to

Content
> The following macros rely on PyGC_Head: (...) I already moved them to the internal C API in commit 1a6be91e6fd65ce9cb88cbbbb193db7e92ec6076 of bpo-35081. But Stefan Behnel reported that it breaks Cython: "Making _PyGC_FINALIZED() internal broke Cython (https://github.com/cython/cython/issues/2721). It's used in the finaliser implementation (https://github.com/cython/cython/blob/da657c8e326a419cde8ae6ea91be9661b9622504/Cython/Compiler/ModuleNode.py#L1442-L1456), to determine if an object for which tp_dealloc() is called has already been finalised or whether we have to do it. I'm not sure how to deal with this on our side now. Any clue?" https://bugs.python.org/issue35081#msg330045 So I simply reverted (partially) this change: commit 3e21ad1a254cc33e8d4920ad7f026254ec728bee.

Content

> The following macros rely on PyGC_Head: (...)

I already moved them to the internal C API in commit  1a6be91e6fd65ce9cb88cbbbb193db7e92ec6076 of bpo-35081.

But Stefan Behnel reported that it breaks Cython:

"Making _PyGC_FINALIZED() internal broke Cython (https://github.com/cython/cython/issues/2721). It's used in the finaliser implementation (https://github.com/cython/cython/blob/da657c8e326a419cde8ae6ea91be9661b9622504/Cython/Compiler/ModuleNode.py#L1442-L1456), to determine if an object for which tp_dealloc() is called has already been finalised or whether we have to do it. I'm not sure how to deal with this on our side now. Any clue?"

https://bugs.python.org/issue35081#msg330045

So I simply reverted (partially) this change: commit 3e21ad1a254cc33e8d4920ad7f026254ec728bee.

History
Date	User	Action	Args
2020-04-10 00:18:59	vstinner	set	recipients: + vstinner
2020-04-10 00:18:59	vstinner	set	messageid: <1586477939.23.0.270435463457.issue40241@roundup.psfhosted.org>
2020-04-10 00:18:59	vstinner	link	issue40241 messages
2020-04-10 00:18:58	vstinner	create