Message 396919 - Python tracker

Message396919

Author	Kronuz
Recipients	Kronuz, Nils Kattenbeck, gvanrossum, keithblaha, kj, levkivskyi
Date	2021-07-03.18:01:04
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1625335264.76.0.200794291228.issue41249@roundup.psfhosted.org>
In-reply-to

Content
The way I fixed this is I added `__forward_module__` to `typing.ForwardRef`, so that it can resolve the forward reference with the same globals as the ones specified by the module in `__forward_module__`. `TypedDict`'s metaclass should then pass the dictionary’s module name to the annotations’ forward references via the added `module`’s keyword argument in `typing._type_check()`. I can work in a pull request with this solution and discuss any potential problems.

Content

The way I fixed this is I added `__forward_module__` to `typing.ForwardRef`, so that it can resolve the forward reference with the same globals as the ones specified by the module in `__forward_module__`. `TypedDict`'s metaclass should then pass the dictionary’s module name to the annotations’ forward references via the added `module`’s keyword argument in `typing._type_check()`. I can work in a pull request with this solution and discuss any potential problems.

History
Date	User	Action	Args
2021-07-03 18:01:04	Kronuz	set	recipients: + Kronuz, gvanrossum, levkivskyi, Nils Kattenbeck, keithblaha, kj
2021-07-03 18:01:04	Kronuz	set	messageid: <1625335264.76.0.200794291228.issue41249@roundup.psfhosted.org>
2021-07-03 18:01:04	Kronuz	link	issue41249 messages
2021-07-03 18:01:04	Kronuz	create