Message 402207 - Python tracker

Message402207

Author	vstinner
Recipients	lukasz.langa, miss-islington, serhiy.storchaka, vstinner
Date	2021-09-20.07:56:00
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1632124560.4.0.100336507249.issue45187@roundup.psfhosted.org>
In-reply-to

Content
> bpo-45187: Collect test_socket tests using unittest (GH-28317) Nice enhancement! Thanks. > self.addCleanup(thread.join, self.timeout) I suggest to use test.support.threading_helper.join_thread() to avoid blocking if the thread raises an exception or never completes. The function has a timeout with a reasonable default value (adapted per buildbot).

Content

> bpo-45187: Collect test_socket tests using unittest (GH-28317)

Nice enhancement! Thanks.

> self.addCleanup(thread.join, self.timeout)

I suggest to use test.support.threading_helper.join_thread() to avoid blocking if the thread raises an exception or never completes. The function has a timeout with a reasonable default value (adapted per buildbot).

History
Date	User	Action	Args
2021-09-20 07:56:00	vstinner	set	recipients: + vstinner, lukasz.langa, serhiy.storchaka, miss-islington
2021-09-20 07:56:00	vstinner	set	messageid: <1632124560.4.0.100336507249.issue45187@roundup.psfhosted.org>
2021-09-20 07:56:00	vstinner	link	issue45187 messages
2021-09-20 07:56:00	vstinner	create