Guido van Rossum wrote:
> You might want to compare what I checked in to your patch; I did a few
> style cleanups. I also moved the lseek() call into import.c, where it
> seems more appropriate.
Ah I see that you prefer to keep assignment and check against NULL/-1 on
two separate lines.
I had the lseek() in PyTokenizer_FindEncoding() because I prefer
functions that restore their environment. I find it less surprising when
it restores the position of the file descriptor.
By the way I got Windows, VS 2003 and several SDKs installed in VMWare
today. It's annoying and it takes hours. Most unit tests are passing.
http://wiki.python.org/moin/Building_Python_with_the_free_MS_C_Toolkit