Message 74731 - Python tracker

Message74731

Author	vstinner
Recipients	barry, christian.heimes, donmez, draghuram, exarkun, janssen, loewis, nnorwitz, rtmq, vstinner
Date	2008-10-14.11:27:45
SpamBayes Score	7.846711e-08
Marked as misclassified	No
Message-id	<1223983667.47.0.195770788025.issue1210@psf.upfronthosting.co.za>
In-reply-to

Content
Here is a patch for imaplib: - add encoding attribute to IMAP4 class (as ftplib and see also issue 3727 for my poplib patch) - use makefile('r', encoding=self.encoding) instead of a binary file (mode='rb') - remove duplicate code in IMAP4_SSL I choosed ISO-8859-1 as the default charset. I tested the library on my local IMAP4 server using IMAP4 and IMAP4_SSL classes. But the library needs more unit tests as done for poplib.

Content

Here is a patch for imaplib:
 - add encoding attribute to IMAP4 class (as ftplib and see also issue 
3727 for my poplib patch)
 - use makefile('r', encoding=self.encoding) instead of a binary file 
(mode='rb')
 - remove duplicate code in IMAP4_SSL

I choosed ISO-8859-1 as the default charset. I tested the library on 
my local IMAP4 server using IMAP4 and IMAP4_SSL classes. But the 
library needs more unit tests as done for poplib.

History
Date	User	Action	Args
2008-10-14 11:27:49	vstinner	set	recipients: + vstinner, loewis, barry, nnorwitz, exarkun, janssen, draghuram, christian.heimes, donmez, rtmq
2008-10-14 11:27:47	vstinner	set	messageid: <1223983667.47.0.195770788025.issue1210@psf.upfronthosting.co.za>
2008-10-14 11:27:46	vstinner	link	issue1210 messages
2008-10-14 11:27:46	vstinner	create