Add validation for unique IDs within a document by mpsonntag · Pull Request #303 · G-Node/python-odml
Conversation
To prepare for #258 this PR introduces validation checks for duplicate IDs within a document.
Update:
The github.io documentation now also features the latest version of the data model and a brief description of the commandline convenience scripts.
@jgrewe do you have time to have a look at this?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tiny comment, though
| self.obj = obj | ||
| self.msg = msg | ||
| self.type = type | ||
| self.type = rank |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we use 'rank' in the user facing api, should we also rename type to rank?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed we should!
Good to merge (when the tests finish)?