◐ Shell
clean mode source ↗

PipelineIndentationStyle: Fix edge case where pipeline was incorrectly detected to span mutliple lines due to backticks in the command leading up to the pipeline by bergmeister · Pull Request #1312 · PowerShell/PSScriptAnalyzer

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bergmeister

Copy link Copy Markdown

Collaborator

PR Summary

Fixes #1311 by refining the logic to determine if a pipeline spans one line or not. Previously it compared only the StartLineNumber of the first and last pipeline to be equal. Now the logic needs to be tweaked with an OR condition where also the EndLineNumber of the first and last pipeline is checked for equality.
Code was also made more readable.

PR Checklist

Co-Authored-By: Robert Holt <rjmholt@gmail.com>

@bergmeister bergmeister merged commit 171c81d into PowerShell:master

Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

2 participants

@bergmeister @rjmholt