◐ Shell
clean mode source ↗

Fix configuration for PS v5 and v6 builds to be Debug/Release and not PSV6Debug, etc. as it used to be able to produce actual debug builds by bergmeister · Pull Request #1356 · PowerShell/PSScriptAnalyzer

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bergmeister

@bergmeister bergmeister commented

Oct 26, 2019

edited

Loading

Copy link Copy Markdown

Collaborator

PR Summary

The special PSV4Debug and PSV3Debug configurations apply only to builds of v3 and v4. The other builds do not need that and should just be Debug/Release as a config. At the moment this makes Debug build actually be Release builds, which this PR fixes. cc @thomasrayner
This minor regression was introduced in the build module refactoring of PR #1139

PR Checklist

@bergmeister bergmeister reopened this

Nov 11, 2019

@bergmeister bergmeister merged commit 468212a into PowerShell:master

Nov 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bergmeister @rjmholt