Fix configuration for PS v5 and v6 builds to be Debug/Release and not PSV6Debug, etc. as it used to be able to produce actual debug builds by bergmeister · Pull Request #1356 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Conversation
Collaborator
PR Summary
The special PSV4Debug and PSV3Debug configurations apply only to builds of v3 and v4. The other builds do not need that and should just be Debug/Release as a config. At the moment this makes Debug build actually be Release builds, which this PR fixes. cc @thomasrayner
This minor regression was introduced in the build module refactoring of PR #1139
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
…sed to be to allow for actual debug builds
bergmeister
added
the
Area - Build
label
bergmeister
requested a review
from rjmholt
rjmholt
approved these changes
bergmeister
closed this
bergmeister
reopened this
bergmeister
requested a review
from JamesWTruher
bergmeister
merged commit
468212a
into
PowerShell:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment