Increase maximum runspace pool size in flaky test by bergmeister · Pull Request #1358 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Merged
Conversation
bergmeister
commented
Oct 26, 2019
bergmeister
commented
Collaborator
PR Summary
Increase maximum number over time until we find a stable upper limit. It turns out one cannot do a straightforward calculation of runspaces (either due to complexity or garbage collection)
An example build failure with 14 runspaces is here: https://ci.appveyor.com/project/PowerShell/psscriptanalyzer/builds/28399656/job/8d7spi13o6kekjaw?fullLog=true
cc @thomasrayner for visiblity
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
bergmeister
added
the
Area - Build
label
bergmeister
assigned
JamesWTruher
bergmeister
mentioned this pull request
6 tasks
bergmeister
commented
Nov 11, 2019
bergmeister commented
Collaborator Author
re-trigger ci
bergmeister
closed this
bergmeister
reopened this
bergmeister
requested a review
from JamesWTruher
JamesWTruher
approved these changes
bergmeister
merged commit
86c48b4
into
master
bergmeister
deleted the
bergmeister-patch-2
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment