◐ Shell
clean mode source ↗

Increase maximum runspace pool size in flaky test by bergmeister · Pull Request #1358 · PowerShell/PSScriptAnalyzer

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bergmeister

Copy link Copy Markdown

Collaborator

PR Summary

Increase maximum number over time until we find a stable upper limit. It turns out one cannot do a straightforward calculation of runspaces (either due to complexity or garbage collection)
An example build failure with 14 runspaces is here: https://ci.appveyor.com/project/PowerShell/psscriptanalyzer/builds/28399656/job/8d7spi13o6kekjaw?fullLog=true

cc @thomasrayner for visiblity

PR Checklist

@bergmeister

Copy link Copy Markdown

Collaborator Author

re-trigger ci

@bergmeister bergmeister reopened this

Nov 11, 2019

@bergmeister bergmeister merged commit 86c48b4 into master

Jan 16, 2020

@bergmeister bergmeister deleted the bergmeister-patch-2 branch

February 9, 2020 20:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bergmeister @JamesWTruher