Disable bad tests on Linux for now by rjmholt · Pull Request #1365 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Merged
Conversation
rjmholt
commented
Nov 4, 2019
rjmholt
commented
Contributor
PR Summary
Disables tests that a strangely failing only on Linux in AppVeyor.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
rjmholt
requested review from
JamesWTruher and
bergmeister
bergmeister
reviewed
bergmeister
reviewed
bergmeister
approved these changes
bergmeister
left a comment
bergmeister
left a comment
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor suggestion to disable those 4 tests on appveyor only as those tests pass on azure devops's ubuntu image
Co-Authored-By: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>
rjmholt
merged commit
ca1b7c0
into
PowerShell:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment