Fix rule suppression ID in compat rules by rjmholt · Pull Request #1432 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Merged
Conversation
rjmholt
commented
Apr 3, 2020
Contributor
PR Summary
The ruleId wasn't translated through in the compatibility diagnostic constructor. This fixes that.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
TylerLeonhardt
approved these changes
rjmholt
commented
Apr 3, 2020
rjmholt commented
Contributor Author
bergmeister
approved these changes
bergmeister
left a comment
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can an existing test be enhanced for an additional assertion against the rule id if easily possible? Otherwise LGTM
rjmholt
commented
Apr 3, 2020
rjmholt commented
Contributor Author
Can an existing test be enhanced for an additional assertion against the rule id if easily possible?
I'm thinking a similar thing, but I'd like to do that in a separate PR (which might be able to enhance these suppressions slightly as well)
975fcc6
into
PowerShell:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
