UseConsistentIndentation: When non-default options are used, cater for the case of a comment between pipe and newline by bergmeister · Pull Request #1463 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
merged 8 commits into
Conversation
bergmeister
commented
Apr 26, 2020
Collaborator
PR Summary
Fixed #1459 so that indentation gets increased for setting values of IncreaseIndentationForFirstPipeline or IncreaseIndentationAfterEveryPipeline if there is a comment between pipe and newline (the comment caused it not work because it peeked only at the next token when checking for the newline or line continuation token.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
…r the case of a comment between pipe and newline
rjmholt
reviewed
Rules/UseConsistentIndentation.cs Outdated
bergmeister and others added 7 commits
Co-Authored-By: Robert Holt <rjmholt@gmail.com>
… into UseConsistentIndentation-CommentBetweenPipeAndNewline
https://github.com/bergmeister/psscriptanalyzer into UseConsistentIndentation-CommentBetweenPipeAndNewline
This reverts commit 226259d.
…rectly insert whitespaces in there)
rjmholt
approved these changes
53ece47
into
PowerShell:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
