UseUsingScopeModifierInNewRunspaces: Fix ArgumentException when the same variable name is used in 2 different sessions. by bergmeister · Pull Request #1493 · PowerShell/PSScriptAnalyzer
PR Summary
Fixes #1492 by checking if the variable name was already added. Also simplifying the code to be a HashSet<string> instead of a Dictionary<string,VariableExpressionAst> since the actual variable seems to be never used. Unfortunately I have to drop the IReadOnlyCollection for HashSet since we target .Net 4.5.2 and only starting with .Net 4.6, HashSet is implementing IReadOnlyCollection, see here.
cc @Jawz84
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix