Make CI fail if tests fail and fix failing tests by making them Pester v5 compatible by bergmeister · Pull Request #1553 · PowerShell/PSScriptAnalyzer

PR Summary

The migration to Pester v5 meant that the switch to make CI fail if there was a test failure, was not on. I did an individual commit for this fix so that you can see it fails now when there is a failed test.
Fix failing tests by making them Pester v5 compatible, this was because the PR that added those tests was opened before the Pester v5 migration.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
• Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.