◐ Shell
clean mode source ↗

🧹 Make usage of Microsoft.Management.Infrastructure consistent and reference it only once in CrossCompatibility project by bergmeister · Pull Request #1601 · PowerShell/PSScriptAnalyzer

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bergmeister

Copy link Copy Markdown

Collaborator

PR Summary

This is to have consistency with what we actually already do in the Rules project and its configuration currently applies as it is the 'root' project: https://github.com/PowerShell/PSScriptAnalyzer/blob/master/Rules/Rules.csproj#L18-L2
Since the project depends on CrossCompatibility, we can reference the Microsoft.Management.Infrastructure only once in there to avoid duplication and consistencies that we currently have.

PR Checklist

@rjmholt rjmholt merged commit 553af8b into master

Nov 3, 2020

@rjmholt rjmholt deleted the crosscompat-consistency branch

November 3, 2020 17:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bergmeister @rjmholt