🧹 Make usage of Microsoft.Management.Infrastructure consistent and reference it only once in CrossCompatibility project by bergmeister · Pull Request #1601 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Conversation
bergmeister
commented
Oct 24, 2020
bergmeister
commented
Collaborator
PR Summary
This is to have consistency with what we actually already do in the Rules project and its configuration currently applies as it is the 'root' project: https://github.com/PowerShell/PSScriptAnalyzer/blob/master/Rules/Rules.csproj#L18-L2
Since the project depends on CrossCompatibility, we can reference the Microsoft.Management.Infrastructure only once in there to avoid duplication and consistencies that we currently have.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- x] This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
…tibility project for consistency
bergmeister
added
the
Area - Build
label
bergmeister
requested review from
JamesWTruher and
rjmholt
rjmholt
approved these changes
rjmholt
merged commit
553af8b
into
master
rjmholt
deleted the
crosscompat-consistency
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment